Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 27, 2025

PR-Codex overview

This PR focuses on updating the method calls for interacting with ThirdwebContract to use a static approach, simplifying the syntax and improving clarity in the code.

Detailed summary

  • Updated ThirdwebTransaction preparation to use ThirdwebContract.Prepare.
  • Changed reading method to use ThirdwebContract.Read<T>.
  • Modified writing method to utilize ThirdwebContract.Write for clarity.
  • Simplified method calls by removing the contract parameter in some instances.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Documentation

  • Updated code examples across .NET SDK API documentation for Read, Write, and Prepare methods.
  • Examples now demonstrate both static method invocation patterns and extension method calling styles.
  • Extension method signatures streamlined for improved usability.

✏️ Tip: You can customize this high-level summary in your review settings.

@0xFirekeeper 0xFirekeeper requested review from a team as code owners November 27, 2025 10:35
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 27, 2025 10:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025

⚠️ No Changeset found

Latest commit: 55332cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Building Building Preview Comment Nov 27, 2025 10:35am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Nov 27, 2025 10:35am
thirdweb_playground Skipped Skipped Nov 27, 2025 10:35am
thirdweb-www Skipped Skipped Nov 27, 2025 10:35am
wallet-ui Skipped Skipped Nov 27, 2025 10:35am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Walkthrough

Updates to three .NET SDK documentation pages refactoring API examples to demonstrate static method calls via ThirdwebContract and extension methods, replacing previous instance method patterns for Read, Write, and Prepare operations.

Changes

Cohort / File(s) Summary
API Documentation & Example Updates
apps/portal/src/app/dotnet/contracts/read/page.mdx, apps/portal/src/app/dotnet/contracts/write/page.mdx, apps/portal/src/app/dotnet/transactions/prepare/page.mdx
Updated code examples across three API reference pages to demonstrate new invocation patterns: static calls via ThirdwebContract.Read/Write/Prepare(...) and extension method calls via contract.Read/Write/Prepare(...). Removed contract parameter from extension method signatures and updated example code to reflect the revised API surfaces.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify code examples accurately reflect updated method signatures across all three API pages
  • Confirm extension method signatures match their static counterparts (minus contract parameter)
  • Validate documentation narrative aligns with the new usage patterns shown in examples

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description deviates from the template, missing the required title format, issue tag, reviewer notes, and testing instructions. However, it does provide a summary of changes through the PR-Codex overview. Follow the template format: add proper title with '[SDK/Dashboard/Portal]' prefix, include issue tag (TEAM-0000 format), add specific reviewer notes and testing instructions.
Title check ❓ Inconclusive The title 'small fixes to dotnet docs' is vague and generic, using non-descriptive phrasing that doesn't convey meaningful information about the specific API changes or documentation updates. Replace with a more specific title that highlights the main change, such as 'Update .NET SDK documentation for static method calls' or 'Refactor .NET contract method examples to use static API'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch firekeeper/dotnet-docs-hotfix

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (908142f) to head (55332cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8468   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files         920      920           
  Lines       60891    60891           
  Branches     4144     4144           
=======================================
  Hits        33390    33390           
  Misses      27400    27400           
  Partials      101      101           
Flag Coverage Δ
packages 54.83% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 908142f and 55332cd.

📒 Files selected for processing (3)
  • apps/portal/src/app/dotnet/contracts/read/page.mdx (1 hunks)
  • apps/portal/src/app/dotnet/contracts/write/page.mdx (2 hunks)
  • apps/portal/src/app/dotnet/transactions/prepare/page.mdx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-06T23:47:55.122Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:255-277
Timestamp: 2025-06-06T23:47:55.122Z
Learning: The `transfer` function from `thirdweb/extensions/erc20` accepts human-readable amounts via the `amount` property and automatically handles conversion to base units (wei) by fetching the token decimals internally. Manual conversion using `toWei()` is not required when using the `amount` property.

Applied to files:

  • apps/portal/src/app/dotnet/contracts/write/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Vercel Agent Review
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/portal/src/app/dotnet/contracts/read/page.mdx (1)

14-20: ✓ Consistent API documentation.

The static and extension method signatures are clearly documented and complementary. The removal of the contract parameter from the Parameters section appropriately reflects the new API surface.

apps/portal/src/app/dotnet/transactions/prepare/page.mdx (1)

25-42: ✓ Well-structured documentation with complementary static and extension patterns.

The static and extension method signatures are clearly presented with consistent parameter ordering. The Parameters section (lines 62–84) comprehensively documents both forms, and the post-preparation customization example (lines 46–58) effectively demonstrates the intended workflow.

@0xFirekeeper 0xFirekeeper merged commit 4f2dbcc into main Nov 27, 2025
22 of 24 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/dotnet-docs-hotfix branch November 27, 2025 10:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants