-
Notifications
You must be signed in to change notification settings - Fork 629
small fixes to dotnet docs #8468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughUpdates to three .NET SDK documentation pages refactoring API examples to demonstrate static method calls via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8468 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 920 920
Lines 60891 60891
Branches 4144 4144
=======================================
Hits 33390 33390
Misses 27400 27400
Partials 101 101
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
apps/portal/src/app/dotnet/contracts/read/page.mdx(1 hunks)apps/portal/src/app/dotnet/contracts/write/page.mdx(2 hunks)apps/portal/src/app/dotnet/transactions/prepare/page.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-06T23:47:55.122Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:255-277
Timestamp: 2025-06-06T23:47:55.122Z
Learning: The `transfer` function from `thirdweb/extensions/erc20` accepts human-readable amounts via the `amount` property and automatically handles conversion to base units (wei) by fetching the token decimals internally. Manual conversion using `toWei()` is not required when using the `amount` property.
Applied to files:
apps/portal/src/app/dotnet/contracts/write/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Vercel Agent Review
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/portal/src/app/dotnet/contracts/read/page.mdx (1)
14-20: ✓ Consistent API documentation.The static and extension method signatures are clearly documented and complementary. The removal of the
contractparameter from the Parameters section appropriately reflects the new API surface.apps/portal/src/app/dotnet/transactions/prepare/page.mdx (1)
25-42: ✓ Well-structured documentation with complementary static and extension patterns.The static and extension method signatures are clearly presented with consistent parameter ordering. The Parameters section (lines 62–84) comprehensively documents both forms, and the post-preparation customization example (lines 46–58) effectively demonstrates the intended workflow.
size-limit report 📦
|
PR-Codex overview
This PR focuses on updating the method calls for interacting with
ThirdwebContractto use a static approach, simplifying the syntax and improving clarity in the code.Detailed summary
ThirdwebTransactionpreparation to useThirdwebContract.Prepare.ThirdwebContract.Read<T>.ThirdwebContract.Writefor clarity.contractparameter in some instances.Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.